Skip to content

feat(sidebar): add sub-article navigation#72

Open
omribz156 wants to merge 1 commit into
nodejs:mainfrom
omribz156:codex/add-subarticle-navigation
Open

feat(sidebar): add sub-article navigation#72
omribz156 wants to merge 1 commit into
nodejs:mainfrom
omribz156:codex/add-subarticle-navigation

Conversation

@omribz156
Copy link
Copy Markdown

@omribz156 omribz156 commented May 16, 2026

Summary:

  • Add sidebar entries for nested Diagnostics and Node-API child articles.
  • Keep parent topic pages reachable through Overview links inside each nested group.

Verification:

  • npm run format:check -- site.json
  • npm run lint
  • npm run build
  • Targeted Node script verified every added nested sidebar link exists under pages/.

This was implemented with Codex assistance, with the final diff reviewed before posting.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 16, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-learn Ready Ready Preview May 16, 2026 10:11am

Request Review

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 16, 2026

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website

Please review the changes when you have a chance. Thank you! 🙏

@omribz156 omribz156 changed the title [codex] Add sub-article sidebar navigation Add sub-article sidebar navigation May 16, 2026
@omribz156 omribz156 marked this pull request as ready for review May 16, 2026 10:14
@omribz156 omribz156 requested a review from a team as a code owner May 16, 2026 10:14
@cursor
Copy link
Copy Markdown

cursor Bot commented May 16, 2026 •
edited
Loading

PR Summary

Low Risk
Low risk, data-only navigation changes confined to site.json; main risk is broken/incorrect links or unintended sidebar nesting/ordering.

Overview
Adds nested sidebar navigation under Learn for several Diagnostics topics (Memory, Live Debugging, Poor Performance) and Node-API sections (Getting Started, Build Tools, Special Topics).

Each newly-nested section now includes an explicit Overview child entry so the parent landing page remains directly reachable from the expanded group.

Reviewed by Cursor Bugbot for commit 663332c. Bugbot is set up for automated code reviews on this repo. Configure here.

@mikeesto mikeesto linked an issue May 16, 2026 that may be closed by this pull request
Add Sub-Articles to Navigation #40
Open
@avivkeller avivkeller changed the title Add sub-article sidebar navigation feat9(sidebar): add sub-article navigation May 16, 2026
avivkeller
avivkeller reviewed May 16, 2026
View reviewed changes
Comment thread site.json
@@ -349,15 +349,57 @@
},
{
"link": "/learn/diagnostics/memory",
Copy link
Copy Markdown
Member

@avivkeller avivkeller May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this link can be removed, right?

@avivkeller avivkeller changed the title feat9(sidebar): add sub-article navigation feat(sidebar): add sub-article navigation May 16, 2026
@avivkeller
Copy link
Copy Markdown
Member

avivkeller commented May 24, 2026

Bump @omribz156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avivkeller avivkeller avivkeller approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Sub-Articles to Navigation

2 participants

@omribz156 @avivkeller